Skip to content

Dynamic Config #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 17, 2025
Merged

Dynamic Config #664

merged 21 commits into from
Oct 17, 2025

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Sep 26, 2025 •
edited
Loading

Benefit:
Compatible configs populate the latest value (with respect to the layers) every 30 seconds on running servers without restarting.

Pieces:

  • config.NewDynamic() to create a dynamic type (which can live outside the config tree for computed types)
  • outfit the first config
  • Ensure docs-gen reports the right type and "Updated instantly." suffix.
  • tests
  • Change Notifier which allows computed objects to. adapt to changes.

Decision-Points:

  • 30 seconds poll?

magik6k
magik6k reviewed Oct 4, 2025
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads really well, I like how this refreshes fixed values a lot more than having that bloat directly in each instance of Dynamic.

I'd really like to have some Unit tests for the cursed reflect logic, AI should be pretty great at writing that sort of thing.

Also linters are complaining.

@snadrus snadrus marked this pull request as ready for review October 13, 2025 20:01
@snadrus snadrus requested a review from a team as a code owner October 13, 2025 20:01
@snadrus
Copy link
Contributor Author

snadrus commented Oct 13, 2025

I added a change notifier so that the Addresses_P1-Hard could be more efficient.
There's 1 test failure on happy-path.

@snadrus snadrus requested a review from magik6k October 14, 2025 21:22
@snadrus snadrus mentioned this pull request Oct 15, 2025
Open
@snadrus snadrus requested a review from LexLuthr October 15, 2025 14:53
magik6k
magik6k approved these changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to use this. Couple of probably just questions. Would be nice to ask some AI model to write more unit tests for the dynamic.go

@snadrus snadrus merged commit 09959f3 into main Oct 17, 2025
18 checks passed
@snadrus snadrus deleted the dyn-cfg branch October 17, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magik6k magik6k magik6k approved these changes

@LexLuthr LexLuthr Awaiting requested review from LexLuthr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@snadrus @magik6k